Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cellfinder v1.3.0 blog post #197

Merged
merged 5 commits into from
Jun 4, 2024
Merged

cellfinder v1.3.0 blog post #197

merged 5 commits into from
Jun 4, 2024

Conversation

IgorTatarnikov
Copy link
Member

@IgorTatarnikov IgorTatarnikov commented Jun 3, 2024

Before submitting a pull request (PR), please read the contributing guide.

Please fill out as much of this template as you can, but if you have any problems or questions, just leave a comment and we will help out :)

Description

What is this PR

  • Bug fix
  • Addition of a new feature
  • Other

Why is this PR needed?
We're switching from TensorFlow to a PyTorch backend in cellfinder v1.3.0. This is a major change and should have a blog post along side the release.

What does this PR do?

References

Closes #177

How has this PR been tested?

Build locally and visually inspected.

Is this a breaking change?

No

Does this PR require an update to the documentation?

No

If any features have changed, or have been added. Please explain how the documentation has been updated (and link to the associated PR). See here for details.

Checklist:

  • The code has been tested locally
  • Tests have been added to cover all new functionality (unit & integration)
  • The documentation has been updated to reflect any changes
  • The code has been formatted with pre-commit

@IgorTatarnikov IgorTatarnikov marked this pull request as ready for review June 3, 2024 14:53
@IgorTatarnikov IgorTatarnikov requested a review from a team June 3, 2024 14:53
docs/source/blog/cellfinder-v1_3.md Outdated Show resolved Hide resolved
docs/source/blog/cellfinder-v1_3.md Outdated Show resolved Hide resolved
## What do I need to do?

Since this is a major update, we recommend using a fresh conda environment.
For GPU support, please follow the installation instructions in the [documentation](../documentation/setting-up/gpu.md).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once everything is merged, this will point to new, pytorch-based instructions right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I understand Sphinx correctly then yes, this should point to the instructions as updated in #189!

docs/source/blog/cellfinder-v1_3.md Outdated Show resolved Hide resolved
docs/source/blog/cellfinder-v1_3.md Outdated Show resolved Hide resolved
docs/source/blog/cellfinder-v1_3.md Outdated Show resolved Hide resolved
@adamltyson adamltyson merged commit 310a69e into main Jun 4, 2024
3 checks passed
@adamltyson adamltyson deleted the cellfinder-torch-blogpost branch June 4, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cellfinder v1.3.0 blog post
2 participants