Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency tree in light of widget refactoring. #163

Merged
merged 2 commits into from
Jun 14, 2024

Conversation

willGraham01
Copy link
Contributor

Since brainrender-napari now fetches it's widgets from brainglobe-utils, we need to update the dependency tree to reflect this.

Staging this PR until a new version of the metapackage with all necessary new versions released and updated is ready. @K-Meech

@adamltyson
Copy link
Member

A new version of the metapackage has now been released. There's been some movement of code (e.g. from cellfinder -> brainglobe-utils), but I think the new dependency tree is still valid.

@alessandrofelder
Copy link
Member

I think it's missing the dependency of brainrender-napari on brainglobe-utils, introduced here.

@alessandrofelder
Copy link
Member

...in other words, I think this could/should be merged... but looks like we're replacing a light-mode image with a dark-mode image?

@adamltyson
Copy link
Member

Oh yeah it should probably be in light mode

@alessandrofelder
Copy link
Member

@willGraham01 could you have another look at this and ask for my review?

@willGraham01
Copy link
Contributor Author

Should be in light mode now - I think this was opened with the changes in brainglobe/brainglobe-meta#49 in mind, so if no other package dependencies have been moved around, things should be OK.

@alessandrofelder alessandrofelder marked this pull request as ready for review June 13, 2024 14:31
@alessandrofelder alessandrofelder merged commit 31dcf70 into main Jun 14, 2024
3 checks passed
@alessandrofelder alessandrofelder deleted the widget-dependency-tree-update branch June 14, 2024 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants