Replace source_custom_config_cellfinder with newer function #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uration_path. Changed in brainglobe/cellfinder#394.
IgorTatarnikov
approved these changes
Apr 12, 2024
There was a problem hiding this comment.
Looks good, merging this as we have a tentative fix for the failing tests ready in brainglobe/cellfinder#400
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is this PR
Why is this PR needed?
source_custom_config_cellfinderwas changed touser_specific_configuration_pathin brainglobe/cellfinder#394, so we need to update the usage her as well.What does this PR do?
Updates the usage.
References
Please reference any existing issues/PRs that relate to this PR.
How has this PR been tested?
Made the changes locally so that tests worked.
Is this a breaking change?
No
Does this PR require an update to the documentation?
No
Checklist: