Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move heatmap functionality to brainglobe-utils #74

Merged
merged 1 commit into from
Jan 8, 2024

Conversation

adamltyson
Copy link
Member

Moves the heatmap generation functionality to brainglobe-utils

Part of #73

Depends on brainglobe/brainglobe-utils#22, and tests will fail until that's merged and released.

@adamltyson adamltyson requested a review from a team January 5, 2024 16:28
Copy link
Collaborator

@willGraham01 willGraham01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, pending CI checks once https://github.com/brainglobe/brainglobe-utils/actions/runs/7445454585 completes and releases

Copy link

codecov bot commented Jan 8, 2024

Codecov Report

Attention: 18 lines in your changes are missing coverage. Please review.

Comparison is base (2da996a) 81.39% compared to head (b0a36bf) 82.24%.
Report is 4 commits behind head on main.

Files Patch % Lines
...rainglobe_workflows/brainmapper/analyse/analyse.py 7.14% 13 Missing ⚠️
brainglobe_workflows/brainmapper/main.py 37.50% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #74      +/-   ##
==========================================
+ Coverage   81.39%   82.24%   +0.84%     
==========================================
  Files          32       27       -5     
  Lines        1586     1538      -48     
==========================================
- Hits         1291     1265      -26     
+ Misses        295      273      -22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adamltyson adamltyson merged commit 80d583c into main Jan 8, 2024
9 of 10 checks passed
@adamltyson adamltyson deleted the move-to-brainglobe-utils branch January 8, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants