Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid caching pip dependencies #124

Merged
merged 2 commits into from
Aug 8, 2024
Merged

Avoid caching pip dependencies #124

merged 2 commits into from
Aug 8, 2024

Conversation

alessandrofelder
Copy link
Member

@alessandrofelder alessandrofelder commented Aug 7, 2024

Description

What is this PR

  • Bug fix
  • Addition of a new feature
  • Other

Why is this PR needed?

If we run the benchmarks using the current configurations on a local machine, we risk pip using its cache. This stops the benchmarks from being useful smoke tests for newer versions of dependencies breaking our code, which is a key purpose of this repo.

What does this PR do?
Stops pip from using cached dependencies when installing the package into the asv conda env.

References

\

How has this PR been tested?

Only understanding how pip works better. Suggestions for how to best test this welcome 🤔

Is this a breaking change?

No.

Does this PR require an update to the documentation?

yes, but we should tackle that as a whole once we are happy with the workflows and our internal testing setup.

Checklist:

  • [ \ ] The code has been tested locally
  • [ \ ] Tests have been added to cover all new functionality (unit & integration)
  • [ \ ] The documentation has been updated to reflect any changes
  • The code has been formatted with pre-commit

@alessandrofelder alessandrofelder changed the title ensure pip.conf install latest dependencies Avoid caching pip dependencies Aug 7, 2024
Copy link

codecov bot commented Aug 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.83%. Comparing base (9ad7474) to head (5b6ec05).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #124   +/-   ##
=======================================
  Coverage   85.83%   85.83%           
=======================================
  Files          17       17           
  Lines         847      847           
=======================================
  Hits          727      727           
  Misses        120      120           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alessandrofelder alessandrofelder marked this pull request as ready for review August 7, 2024 14:23
Copy link
Contributor

@sfmig sfmig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Let's hope the canary works next time! 🦜 🤞

We could consider adding -vvv to pip install to get more details for debugging next time (apparently the three are needed, see here). No preference either way so feel free to do as you see fit!

@alessandrofelder alessandrofelder merged commit dbec4e9 into main Aug 8, 2024
13 checks passed
@alessandrofelder alessandrofelder deleted the no-deps-cache branch August 8, 2024 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants