Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cell matching support #74

Merged
merged 14 commits into from
Jun 6, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 43 additions & 0 deletions .github/workflows/test_and_deploy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,10 @@ jobs:
needs: [linting, manifest]
name: ${{ matrix.os }} py${{ matrix.python-version }}
runs-on: ${{ matrix.os }}
env:
# pooch cache dir
BRAINGLOBE_TEST_DATA_DIR: "~/.pooch_cache"

strategy:
matrix:
# Run all supported Python versions on linux
Expand All @@ -41,6 +45,13 @@ jobs:
python-version: "3.11"

steps:
- name: Cache pooch data
uses: actions/cache@v4
with:
path: "~/.pooch_cache"
# hash on conftest in case url changes
key: ${{ runner.os }}-${{ matrix.python-version }}-${{ hashFiles('**/conftest.py') }}
Comment on lines +52 to +53
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# hash on conftest in case url changes
key: ${{ runner.os }}-${{ matrix.python-version }}-${{ hashFiles('**/conftest.py') }}
# hash on conftest in case url changes, or we add files to the pooch registry
key: ${{ runner.os }}-${{ matrix.python-version }}-${{ hashFiles('**/conftest.py') }}

very cool idea to do this 😍


- name: Set up Python ${{ matrix.python-version }}
uses: actions/setup-python@v4
with:
Expand All @@ -55,6 +66,38 @@ jobs:
python-version: ${{ matrix.python-version }}
secret-codecov-token: ${{ secrets.CODECOV_TOKEN }}

test_numba_disabled:
needs: [ linting, manifest ]
name: Run tests with numba disabled
runs-on: ubuntu-latest
env:
NUMBA_DISABLE_JIT: "1"
# pooch cache dir
BRAINGLOBE_TEST_DATA_DIR: "~/.pooch_cache"

steps:
- name: Cache pooch data
uses: actions/cache@v4
with:
path: "~/.pooch_cache"
# hash on conftest in case url changes
key: ${{ runner.os }}-3.11-${{ hashFiles('**/conftest.py') }}

- name: Set up Python
uses: actions/setup-python@v4
with:
python-version: "3.11"
# these libraries enable testing on Qt on linux
- uses: pyvista/setup-headless-display-action@v2
with:
qt: true
# Run test suite with numba disabled
- uses: neuroinformatics-unit/actions/test@v2
with:
python-version: "3.11"
secret-codecov-token: ${{ secrets.CODECOV_TOKEN }}
codecov-flags: "numba"

build_sdist_wheels:
name: Build source distribution
needs: [test]
Expand Down
Loading
Loading