Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update properties panel peer dependency #947

Merged
merged 2 commits into from
Jul 27, 2023
Merged

Conversation

smbea
Copy link
Contributor

@smbea smbea commented Jul 27, 2023

No description provided.

@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Jul 27, 2023
@smbea smbea requested review from barmac, a team and marstamm and removed request for a team July 27, 2023 08:31
@@ -114,7 +114,7 @@
"zeebe-bpmn-moddle": "^0.19.0"
},
"peerDependencies": {
"@bpmn-io/properties-panel": ">= 2.2",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it not work with 2.x anymore? If so, that should be marked in breaking changes...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing breaks. But the new tooltips feature doesn't work, and since some descriptions were migrated to tooltips, then "nothing" appears. I already released these as a breaking change in version v4

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK so we basically fix the peer dependency change which was already released as a breaking change with v4. Potentially we could also include that in the breaking changes section in CHANGELOG. Still, that shouldn't be a problem for users, especially as the release is so recent.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mention that it needs @bpmn-io/properties-panel": ">= 3.2 now? I noticed we've never mentioned this in "breaking changes"

@smbea smbea merged commit 2305e3c into master Jul 27, 2023
9 checks passed
@smbea smbea deleted the update-properties-panel branch July 27, 2023 09:17
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants