Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(element-templates): open custom groups #621

Merged
merged 1 commit into from
Mar 29, 2022

Conversation

marstamm
Copy link
Contributor

@marstamm marstamm commented Mar 22, 2022

Recording 2022-03-29 at 16 38 45

Try it out with npx @bpmn-io/sr bpmn-io/bpmn-js-properties-panel#618-element-template-sections -c 'npm run start:cloud-templates'

closes #618

Applying a entriesVisible template can open other groups. This is a bug that was present before, I created #620 to track it

@nikku
Copy link
Member

nikku commented Mar 24, 2022

Please ping me once there is something I can try out, interaction wise.

@marstamm marstamm force-pushed the 618-element-template-sections branch 2 times, most recently from 8539e3f to eafc9c3 Compare March 29, 2022 12:37
@marstamm marstamm force-pushed the 618-element-template-sections branch from eafc9c3 to 60644cb Compare March 29, 2022 12:54
@marstamm marstamm marked this pull request as ready for review March 29, 2022 14:39
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Mar 29, 2022
@marstamm marstamm requested review from pinussilvestrus, a team and Skaiir and removed request for a team March 29, 2022 14:39
@marstamm
Copy link
Contributor Author

@nikku , you can try it out with npx @bpmn-io/sr bpmn-io/bpmn-js-properties-panel#618-element-template-sections -c 'npm run start:cloud-templates'

Copy link
Member

@nikku nikku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as intended, and simple enough in terms of implementation.

Good job 👏

@fake-join fake-join bot merged commit 50e5a9d into master Mar 29, 2022
@fake-join fake-join bot deleted the 618-element-template-sections branch March 29, 2022 22:14
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow sections to be opened per default
2 participants