Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display link to element template documentation #616

Closed
2 tasks
nikku opened this issue Mar 17, 2022 · 8 comments · Fixed by #629
Closed
2 tasks

Display link to element template documentation #616

nikku opened this issue Mar 17, 2022 · 8 comments · Fixed by #629
Assignees

Comments

@nikku
Copy link
Member

nikku commented Mar 17, 2022

Is your feature request related to a problem? Please describe

As a user I want to be able to read documentation related to a specific task type ("element template"), if provided (#614):

image

Describe the solution you'd like

Describe alternatives you've considered

None.


Depends on #614.

@nikku nikku added the enhancement New feature or request label Mar 17, 2022
@pinussilvestrus
Copy link
Contributor

This also depends on how much the panel header is aware of element templates: #610 (comment) + #610 (comment)

@pinussilvestrus pinussilvestrus self-assigned this Mar 21, 2022
@pinussilvestrus
Copy link
Contributor

@currandwyer is the icon already available to use?

image

@nikku
Copy link
Member Author

nikku commented Mar 22, 2022

<svg width="12" height="12" viewBox="0 0 12 12" fill="none" xmlns="http://www.w3.org/2000/svg">
<path fill-rule="evenodd" clip-rule="evenodd" d="M10.064 10.0646V5.66793H11.3333V10.0653C11.3333 10.3998 11.2055 10.6949 10.9499 10.9505C10.6943 11.2061 10.3992 11.334 10.0646 11.334H1.26933C0.915062 11.334 0.614938 11.211 0.368963 10.965C0.122988 10.719 0 10.4189 0 10.0646V1.26933C0 0.915062 0.122988 0.614938 0.368963 0.368963C0.614938 0.122988 0.915062 0 1.26933 0H5.66667V1.26933H1.26933V10.0646H10.064ZM11.3338 0.00160619H6.93648L6.93585 0.000976562V1.27031H9.17922L3.01074 7.43879L3.896 8.32405L10.0645 2.15557V4.39894H11.3338V0.00160619Z" fill="#818698"/>
</svg>

This is the icon. @currandwyer Please share design resources with @pinussilvestrus where approprate, too.

@pinussilvestrus pinussilvestrus added ready Ready to be worked on and removed backlog Queued in backlog labels Mar 22, 2022
pinussilvestrus pushed a commit to bpmn-io/properties-panel that referenced this issue Mar 22, 2022
pinussilvestrus pushed a commit to bpmn-io/properties-panel that referenced this issue Mar 24, 2022
@pinussilvestrus
Copy link
Contributor

This is kind of related to make it possible to display URLs in descriptions: #626

However, as I understand it, the goal here should be to make documentation URLs easier discoverable, without having to open the template section.

pinussilvestrus pushed a commit to bpmn-io/properties-panel that referenced this issue Mar 25, 2022
pinussilvestrus pushed a commit to bpmn-io/properties-panel that referenced this issue Mar 25, 2022
@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on and removed ready Ready to be worked on labels Mar 25, 2022
pinussilvestrus pushed a commit that referenced this issue Mar 25, 2022
@pinussilvestrus
Copy link
Contributor

The basic implementation is done via

Kapture 2022-03-25 at 14 45 12

I will conduct a chat with @currandwyer to clarify the design of the link. We have other places where we have action icons (e.g. add, collapse) and I believe we should make sure they behave similarly.

@nikku
Copy link
Member Author

nikku commented Mar 25, 2022

Looks great already. The icon does not seem to be aligned vertically on the header though. Is this intentional? Looks a bit disturbing I think.

@pinussilvestrus
Copy link
Contributor

pinussilvestrus commented Mar 25, 2022

Looks great already. The icon does not seem to be aligned vertically on the header though. Is this intentional? Looks a bit disturbing I think.

I didn't style it at all so far, only dropped the icon and aligned it to the right 🙂

@nikku
Copy link
Member Author

nikku commented Mar 25, 2022

Interestingly I'm using a slightly different icon (this one). @currandwyer please point to source of truth.

pinussilvestrus pushed a commit to bpmn-io/properties-panel that referenced this issue Mar 25, 2022
pinussilvestrus pushed a commit to bpmn-io/properties-panel that referenced this issue Mar 28, 2022
pinussilvestrus pushed a commit to bpmn-io/properties-panel that referenced this issue Mar 28, 2022
pinussilvestrus pushed a commit to bpmn-io/properties-panel that referenced this issue Mar 28, 2022
pinussilvestrus pushed a commit that referenced this issue Mar 28, 2022
pinussilvestrus pushed a commit to bpmn-io/properties-panel that referenced this issue Mar 28, 2022
pinussilvestrus pushed a commit that referenced this issue Mar 29, 2022
pinussilvestrus pushed a commit that referenced this issue Mar 29, 2022
pinussilvestrus pushed a commit that referenced this issue Mar 29, 2022
pinussilvestrus pushed a commit that referenced this issue Mar 29, 2022
pinussilvestrus pushed a commit that referenced this issue Mar 29, 2022
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Mar 29, 2022
@fake-join fake-join bot closed this as completed in #629 Mar 29, 2022
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Mar 29, 2022
fake-join bot pushed a commit that referenced this issue Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants