Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support documentation URL in element template #614

Closed
1 task
nikku opened this issue Mar 17, 2022 · 7 comments · Fixed by #629
Closed
1 task

Support documentation URL in element template #614

nikku opened this issue Mar 17, 2022 · 7 comments · Fixed by #629
Assignees

Comments

@nikku
Copy link
Member

nikku commented Mar 17, 2022

Is your feature request related to a problem? Please describe

As a user I want to see detailed documentation for a templated task, to be shown in the properties panel as well as the template chooser.

Describe the solution you'd like

  • I can attach a documentation URL to an elemen template

Describe alternatives you've considered

None.

Additional context

Example showing an integration into the properties panel:

image

Example showing an integration into the element / template chooser:

image


Related to #610.

@pinussilvestrus
Copy link
Contributor

I would imagine it something like

// Element Template
{
  "name": "My Task",
  "id": "com.camunda.example.MyTask",
  "appliesTo": [ "bpmn:ServiceTask" ],
  "description": "An example task",
  "documentationRef": "https://www.example.com/myTask"
}
// JSON Schema
{
  "documentationRef": {
    "$id": "#/documentaionRef",
    "type": "string",
    "pattern": "^(https|http)://.*", // or whatever pattern we use
    "errorMessage": {
      "pattern": "Malformed documentation URL"
    }
  }
}

@nikku
Copy link
Member Author

nikku commented Mar 17, 2022

Yes, that makes sense as a start. We can relax it at a future date (i.e. also allow relative URLs).

@pinussilvestrus pinussilvestrus self-assigned this Mar 21, 2022
@pinussilvestrus
Copy link
Contributor

@MaxTru @marstamm could you maybe have a look at my proposal (cf. #614 (comment))? If there is nothing against it, I could already start bringing the new property to the Schema.

I would even say let's support it for both 7 and 8, there is no reason to only focus it on Camunda Platform 8.

@marstamm
Copy link
Contributor

I don't see any problems with this approach, I think we can go ahead with it

@pinussilvestrus pinussilvestrus added ready Ready to be worked on and removed backlog Queued in backlog labels Mar 21, 2022
@MaxTru
Copy link
Contributor

MaxTru commented Mar 21, 2022

👍 from me as well

pinussilvestrus pushed a commit to camunda/element-templates-json-schema that referenced this issue Mar 21, 2022
pinussilvestrus pushed a commit to camunda/element-templates-json-schema that referenced this issue Mar 21, 2022
merge-me bot pushed a commit to camunda/element-templates-json-schema that referenced this issue Mar 22, 2022
merge-me bot pushed a commit to camunda/element-templates-json-schema that referenced this issue Mar 22, 2022
@pinussilvestrus
Copy link
Contributor

This is fixed upstream via camunda/element-templates-json-schema#47. A schema release is pending, though.

@pinussilvestrus pinussilvestrus added fixed upstream Requires integration of upstream change and removed ready Ready to be worked on labels Mar 24, 2022
@MaxTru
Copy link
Contributor

MaxTru commented Mar 25, 2022

Implementation to follow-up with: #616

pinussilvestrus pushed a commit that referenced this issue Mar 29, 2022
@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on needs review Review pending and removed fixed upstream Requires integration of upstream change in progress Currently worked on labels Mar 29, 2022
@fake-join fake-join bot closed this as completed in #629 Mar 29, 2022
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Mar 29, 2022
fake-join bot pushed a commit that referenced this issue Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants