fix: Fix JSON response validation retry strategy #831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
congminh1254
changed the title
congminh1254
changed the title
Pull Request Test Coverage Report for Build 5718880988
💛 - Coveralls |
boxsdk/session/session.py
Outdated
| :param request: | ||
| The API request that could be unsuccessful. | ||
| """ | ||
| if request.expect_json_response and not is_json_response(network_response): |
There was a problem hiding this comment.
could be simplified to simple return statement.
There was a problem hiding this comment.
if function return bool it is a good practice to name functions strating from is_...
There was a problem hiding this comment.
maybe _is_json_response_if_expected, or sth like this
boxsdk/session/session.py
Outdated
| @@ -398,6 +413,10 @@ def _get_retry_request_callable( | |||
| self._send_request, | |||
| ) | |||
| code = network_response.status_code | |||
|
|
|||
| if request.method == 'GET' and network_response and network_response.ok and not self._validate_json_response(network_response, request): | |||
There was a problem hiding this comment.
Why request.method == 'GET' when makin Post which return json it can also happen
There was a problem hiding this comment.
and network_response is it necessary ? if network_response is None: case is handled above
boxsdk/session/session.py
Outdated
| @@ -398,6 +413,10 @@ def _get_retry_request_callable( | |||
| self._send_request, | |||
| ) | |||
| code = network_response.status_code | |||
|
|
|||
| if request.method == 'GET' and network_response and network_response.ok and not self._validate_json_response(network_response, request): | |||
| return self._send_request | |||
There was a problem hiding this comment.
Partial should be used to apply exponential backoff logic
test/unit/session/test_session.py
Outdated
|
|
||
| def test_box_session_raises_for_non_json_response_after_retry(box_session, mock_network_layer, non_json_response, test_url): | ||
| # pylint:disable=redefined-outer-name | ||
| API.MAX_RETRY_ATTEMPTS = 1 |
There was a problem hiding this comment.
NO need to modufy this variable at all now!
lukaszsocha2
approved these changes
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.