Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update proxy-agent usage, drop support Node 12 #865

Merged
merged 10 commits into from
Nov 3, 2023

Conversation

congminh1254
Copy link
Member

@congminh1254 congminh1254 commented Nov 3, 2023

Closes: box/boxcli#505

While bumping the proxy-agent from version 5 to 6, the import syntax changed from:

var ProxyAgent = require('proxy-agent');

to

import { ProxyAgent } from 'proxy-agent';

And proxy-agent is not supporting Node 12 anymore.

@coveralls
Copy link
Collaborator

coveralls commented Nov 3, 2023

Pull Request Test Coverage Report for Build 6747352852

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 95.672%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/util/config.ts 0 1 0.0%
Totals Coverage Status
Change from base Build 6744241683: 0.0%
Covered Lines: 2956
Relevant Lines: 3058

💛 - Coveralls

@congminh1254 congminh1254 changed the title fix: Update proxy-agent usage fix: Update proxy-agent usage, drop support Node 12 Nov 3, 2023
mhagmajer
mhagmajer previously approved these changes Nov 3, 2023
Copy link
Contributor

@mhagmajer mhagmajer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also bump the engine version in package.json

@congminh1254 congminh1254 merged commit e229d3f into main Nov 3, 2023
11 checks passed
@congminh1254 congminh1254 deleted the update-proxy-agent branch November 3, 2023 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using Proxy causes ”Agent is not a constructor” error
3 participants