replace dependency to atty for windows targets by std implementation #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… introduced with Rust 1.70.0
|
Thanks! Released in https://github.com/borntyping/rust-simple_logger/releases/tag/v4.2.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I replaced the use of atty by the just introduced IsTerminal in std Rust.
The downside is, that this bumps MSRV to 1.70.0 but only for Windows targets which use the colored feature.
But for people who do not need or want to use the colored feature of simple_logger, this would completely remove the dependency on atty which is not maintained any more as mentioned e.g. in #74