Fix many, many obvious test bugs #1212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Needed for tests to pass with 128 bit long double types
mborland
approved these changes
Oct 15, 2024
|
Only CI failure is fail to clone on an s390x device (happens semi-regularly). Merging. |
jzmaddock
reviewed
Oct 16, 2024
| @@ -536,7 +547,7 @@ BOOST_AUTO_TEST_CASE_TEMPLATE(atan2_function, T, all_float_types) { | |||
| auto y = y_sampler.next(); | |||
|
|
|||
| auto autodiff_v = atan2(make_fvar<T, m>(x), make_fvar<T, m>(y)); | |||
| auto anchor_v = atan2(x, y); | |||
| auto anchor_v = atan2_wrap(x, y); | |||
There was a problem hiding this comment.
Just curious: what was the issue here? Surely the using std::atan2 should take care of things?
There was a problem hiding this comment.
Sorry, maybe I should have added a comment. The problem is the boost types (real_concept I think in this case), they do not add a std::atan2 overload, so it fails.
There is a using std::atan2 but that has no effect in the presence of the C function, at least for this.
Maybe there is a more clever way, or maybe boost should provide a single overload that works for everything so no such hacks are needed...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed for tests to pass with 128 bit long double types