chore: PlaybackInteractor 비즈니스 로직 수정 및 테스트 추가 #345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 2d57030)
return Task Type에서 async로 변경 (cherry picked from commit bcd0934)
(cherry picked from commit 77c62a8)
(cherry picked from commit 72e548a)
(cherry picked from commit 166e756)
(cherry picked from commit 244a6ca)
유경님 리뷰사항 반영 (cherry picked from commit eaa59c0)
(cherry picked from commit 99445c7)
loinsir
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧑🚀 PR 요약
PlaybackInteractor에서 Task<Bool, Never>로 리턴하던 메소드들을 async로 변경
변경함과 동시에 테스트 함수 추가
테스트 함수가 async걸어 놓으면 에러가 떠서(왜 그런지는 몰겠음) Task로 감쌈
Linked Issue
close #336