test: Setting VIP 테스트코드 작성, 실패 메시지 문구 반대로 작성된 것 수정 #322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chopmozzi
approved these changes
Dec 13, 2023
iOS/Layover/LayoverTests/Scenes/Setting/SettingViewControllerTests.swift
Outdated
Show resolved
Hide resolved
anyukyung
approved these changes
Dec 13, 2023
anyukyung
reviewed
Dec 13, 2023
|
|
||
| // act | ||
| sut.performUserWithdraw(request: request) | ||
| try await Task.sleep(nanoseconds: 3_000_000_000) |
There was a problem hiding this comment.
요방법 생각보다 나쁘지 않은 것 같아요 환경에 따라 실행되는 시간이 다를 수 있다는게 큰 흠이긴 하지만..
There was a problem hiding this comment.
다 바꾸는게 또 일이 될 것 같네요...
There was a problem hiding this comment.
이 방법의 단점에 대해 또 방금 짜면서 느꼈는데, 블랙박스 테스트가 되질 않는다는 점...이 단점이겠네요
There was a problem hiding this comment.
네.. 내부에서 비동기 메소드를 호출하는지 안하는지 알고있어야..... 할 것 같아요 🙀
There was a problem hiding this comment.
이건 그러면 interactor의 메서드들을 async로 전환하고, 사용하는 쪽인 뷰컨에서 Task로 감싸 사용하는 것으로 하겠습니다~
anyukyung
reviewed
Dec 13, 2023
iOS/Layover/LayoverTests/Scenes/Setting/SettingViewControllerTests.swift
Outdated
Show resolved
Hide resolved
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧑🚀 PR 요약
Linked Issue
close #316