Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ViewPager in RecyclerView 성능 개선을 위해 코루틴 적용 #114

Merged
merged 3 commits into from
Nov 11, 2021

Conversation

PsPLoG
Copy link
Collaborator

@PsPLoG PsPLoG commented Nov 10, 2021

what is this pr

Relative: #104

Changes

  • GridLayoutManager가 diffUtils를 사용할 때 역순으로 binding되는 문제 때문에 ListAdapter 제거
  • 달력 생성 및 binding할 때 UI delay를 줄이기 위해 코루틴 적용 (임시 해결책 근본적인 해결이 필요)

…코루틴 적용, ListAdapter 제거

-  GridLayoutManager가 diffUtils를 사용할 때 역순으로 binding되는 문제 때문에 ListAdapter 제거
- 달력 생성 및 binding할 때 UI delay를 줄이기 위해 코루틴 적용 (임시 해결책 근본적인 해결이 필요)
Copy link
Collaborator

@Cha-Ji Cha-Ji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator

@simeunseok simeunseok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Collaborator

@shshksh shshksh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Comment on lines 43 to 45

timeTest = System.currentTimeMillis()
Log.e(this::class.simpleName, "setItems")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

성능 측정이 끝났으면 테스트 로그는 없어도 될 것 같아요

@PsPLoG PsPLoG merged commit cca8a1a into boostcampwm-2021:develop Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants