Clear uploaded manifests on startup #51
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
closes #13 > [Because uploaded] manifests are stored under > [a local directory which] never gets cleared > and fills up over time.
richdouglasevans
changed the title
| @@ -10,7 +10,7 @@ See this Wiki page for instructions on how to use the IIIF manifest editor: | |||
|
|
|||
| ## Online Demo | |||
| You can find online demos of the IIIF Manifest Editor here: | |||
| * [https://iiif.bodleian.ox.ac.uk/manifest-editor/](http://iiif.bodleian.ox.ac.uk/manifest-editor/) | |||
| * [https://digital.bodleian.ox.ac.uk/manifest-editor/](http://digital.bodleian.ox.ac.uk/manifest-editor/) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #13
Bit Old This Issue Innit?
Clearly I pick issues based on their burning and vital importance 😆Yeah, I was just surfing the code—as you do—and thought I'd smash out a few of the open issues. (Yep, more PRs incoming.)
Tests?
Honestly, I'm expecting this PR to be declined 😄because:
I could write tests for this:
But, I'd reckon I'd have to refactor the way the server is spun up to make that test easy to write and that's a bit more effort than just banging in something that works to test the waters about whether this is really an issue or not.
😄
I have tested this manually—that old chestnut—and it ::koff:: "works on my machine" 😆