Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 305-startlevels.md - fix 404 link #5775

Merged
merged 1 commit into from
Sep 18, 2023

Conversation

chrisrueger
Copy link
Contributor

@chrisrueger chrisrueger commented Sep 14, 2023

I found some broken links in the documentation and trying to fix.

@chrisrueger
Copy link
Contributor Author

chrisrueger commented Sep 14, 2023

@pkriens Question:

There is a broken link to a non-existing contact.html e.g. /releases/4.0.0/contact.html in the footer of all older releases pages. I think it could be fixed with something like this:

image

Is this something which should be done? I have the fix ready using a regex search&replace. But it touches almost 5000 files.
Or should older relase files stay untouched?

Another question:
On https://bnd.bndtools.org/releases/4.3.0/chapters/250-resolving.html there is a broken link to /qs/050-start.html

Do you know which could be the correct target url?

@pkriens
Copy link
Member

pkriens commented Sep 15, 2023

I do not think we should update the files in docs/releases. They are a snapshot copy for archival reasons. Some broken links are to be expected.

@pkriens
Copy link
Member

pkriens commented Sep 15, 2023

Can you make sure you sign the commit with your email? I cannot merge it without

@chrisrueger
Copy link
Contributor Author

Can you make sure you sign the commit with your email? I cannot merge it without

Done

@kriegfrj
Copy link
Contributor

Thanks @chrisrueger !

@kriegfrj kriegfrj merged commit 6e36379 into bndtools:master Sep 18, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants