Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old Indicators widget #532

Merged

Conversation

rafaellehmkuhl
Copy link
Member

It was used for testing and can now be replaces by VeryGenericIndicator mini-widgets as desired.

It was used for testing and can now be replaces by `VeryGenericIndicator` mini-widgets as desired.
@joaoantoniocardoso
Copy link
Member

Do we have the templates using the VeryGenericIndicator to replace those old widgets?

@rafaellehmkuhl
Copy link
Member Author

Do we have the templates using the VeryGenericIndicator to replace those old widgets?

We don't, although I would say this is not necessary, as most of those are available as rich data somewhere else now (attitude, coordinates, altitude, vehicle state, etc).

@rafaellehmkuhl rafaellehmkuhl merged commit 54a992b into bluerobotics:master Oct 24, 2023
7 checks passed
@rafaellehmkuhl
Copy link
Member Author

Do we have the templates using the VeryGenericIndicator to replace those old widgets?

We don't, although I would say this is not necessary, as most of those are available as rich data somewhere else now (attitude, coordinates, altitude, vehicle state, etc).

@joaoantoniocardoso I noticed we do have some vehicle-related data that is not available anywhere else (firmware and vehicle type).

Although one can use the VeryGenericIndicator for those, I'm opening an issue to track the addition of those somewhere in the application.

@rafaellehmkuhl rafaellehmkuhl deleted the remove-indicators-widget branch October 24, 2023 21:22
@ES-Alexander ES-Alexander added the docs-needed Change needs to be documented label Nov 23, 2023
ES-Alexander added a commit to ES-Alexander/ardusub-zola that referenced this pull request Nov 23, 2023
ES-Alexander added a commit to ES-Alexander/ardusub-zola that referenced this pull request Nov 23, 2023
ES-Alexander added a commit to ES-Alexander/ardusub-zola that referenced this pull request Nov 23, 2023
ES-Alexander added a commit to ES-Alexander/ardusub-zola that referenced this pull request Nov 23, 2023
ES-Alexander added a commit to ES-Alexander/ardusub-zola that referenced this pull request Nov 23, 2023
ES-Alexander added a commit to ES-Alexander/ardusub-zola that referenced this pull request Nov 24, 2023
ES-Alexander added a commit to ES-Alexander/ardusub-zola that referenced this pull request Nov 24, 2023
ES-Alexander added a commit to ES-Alexander/ardusub-zola that referenced this pull request Nov 24, 2023
ES-Alexander added a commit to ES-Alexander/ardusub-zola that referenced this pull request Nov 24, 2023
ES-Alexander added a commit to ES-Alexander/ardusub-zola that referenced this pull request Nov 24, 2023
ES-Alexander added a commit to ES-Alexander/ardusub-zola that referenced this pull request Nov 24, 2023
ES-Alexander added a commit to bluerobotics/ardusub-zola that referenced this pull request Nov 24, 2023
ES-Alexander added a commit to bluerobotics/ardusub-zola that referenced this pull request Nov 24, 2023
ES-Alexander added a commit to bluerobotics/ardusub-zola that referenced this pull request Nov 24, 2023
@ES-Alexander ES-Alexander added docs-complete Change documentation has been completed and removed docs-needed Change needs to be documented labels Nov 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-complete Change documentation has been completed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants