Compass fix head up #524
Merged
Compass fix head up #524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickelectric
requested review from
Williangalvani,
joaoantoniocardoso and
rafaellehmkuhl
rafaellehmkuhl
requested changes
Oct 19, 2023
src/components/widgets/Compass.vue
Outdated
Comment on lines
10
to
18
| <Dialog v-model:show="widget.managerVars.configMenuOpen" class="w-72"> | ||
| <div class="w-full h-full"> | ||
| <div class="flex flex-col items-center justify-around"> | ||
| <div class="flex items-center justify-between w-full my-1"> | ||
| <span class="mr-1 text-slate-100">Heading style</span> | ||
| <div class="w-40"><Dropdown v-model="widget.options.headingStyle" :options="headingOptions" /></div> | ||
| </div> | ||
| </div> | ||
| </div> | ||
| </Dialog> | ||
| <v-dialog v-model="widget.managerVars.configMenuOpen" min-width="200" max-width="20%"> | ||
| <v-card class="pa-2"> | ||
| <v-card-title>Settings</v-card-title> | ||
| <v-card-text> | ||
| <span class="text-xs font-semibold leading-3 text-slate-600">Style</span> | ||
| <Dropdown v-model="widget.options.headingStyle" :options="headingOptions" /> | ||
| </v-card-text> | ||
| </v-card> | ||
| </v-dialog> |
There was a problem hiding this comment.
Just to be sure, what was wrong here?
Also, we are trying to move away from Vuetify components in Cockpit, so it would be good not to add them back.
|
@patrickelectric I think till you get the HTML right or see if it was a problem on your setup, the second commit, fixing the head-up configuration, is worth merging already. |
Signed-off-by: Patrick José Pereira <[email protected]>
patrickelectric
force-pushed
the
update-heading
branch
from
7263f7e
to
c30c36c
Compare
|
@rafaellehmkuhl check now |
rafaellehmkuhl
approved these changes
Oct 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screen.Recording.2023-10-18.at.19.01.46.mov