StatsForNerds: cleanup and plot packets lost #1414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -138,13 +142,15 @@ const webrtcStats = new WebRTCStats({ getStatsInterval: 100 }) | |||
| function update(): void { | |||
| framerateData.value.push(framerate) | |||
| bitrateData.value.push(bitrate) | |||
| packetLostData.value.push(Math.min(packetLostDelta, maxPacketLost)) | |||
There was a problem hiding this comment.
Won't this put a roof on 10?
There was a problem hiding this comment.
yes. the reasoning here is that the number of lost packets is not as relevant as the fact that packets were lost, so if I left it "unbounded", and we had 1000 packets lost between two messages, our ceiling would go to 1000. If we then lost 1 packet, it would be so small in the plot we wouldn't be able to see them.
In this image, for instance, I don't really care about how many packets were lost. I care that they were lost and we managed to recover.
Does that make sense?
TLDR: I put a low value so we can always notice EVERY packet lost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new red plot line for (instant) packet loss.
useful for correlating video freezes to packet loss