Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix generation of arm64 flatpaks #1409

Conversation

rafaellehmkuhl
Copy link
Member

@rafaellehmkuhl rafaellehmkuhl commented Oct 15, 2024

Apparently the arm64 flatpaks that were being generated (previously to all those CI changes) were actually just renamed x86 flatpaks.

This got caught during the CI changes (making the actions fail) as we aren't forcing the artifact names anymore.

This is now fixed.

@rafaellehmkuhl rafaellehmkuhl force-pushed the make-sure-artifacts-doesnt-mix branch 5 times, most recently from 7813f3e to 6e1987d Compare October 16, 2024 02:08
Previously the "arm" flatpak artifacts were actually x64 ones, worngly build and renamed.

This commit also makes sure to use the exactly artifacts names on upload.
@rafaellehmkuhl rafaellehmkuhl changed the title Make sure CI artifacts do not get mixed Fix generation of arm64 flatpaks Oct 16, 2024
@rafaellehmkuhl rafaellehmkuhl marked this pull request as ready for review October 16, 2024 02:23
@ArturoManzoli ArturoManzoli merged commit 23d889a into bluerobotics:master Oct 16, 2024
10 checks passed
@rafaellehmkuhl rafaellehmkuhl deleted the make-sure-artifacts-doesnt-mix branch October 16, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants