Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create VideoPlayerStatsForNerds.vue #1403

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

Williangalvani
Copy link
Member

Screen.Recording.2024-10-11.at.22.51.53.mov

Screenshot 2024-10-11 at 22 52 33

@Williangalvani Williangalvani force-pushed the stats_for_nerds branch 2 times, most recently from 4fcbc6c to 95d788c Compare October 15, 2024 19:39
@Williangalvani
Copy link
Member Author

added more stuff, don't want to add any more
Screenshot 2024-10-16 at 19 02 11

@Williangalvani Williangalvani marked this pull request as ready for review October 16, 2024 22:03
@ES-Alexander ES-Alexander added the docs-needed Change needs to be documented label Oct 16, 2024
@ES-Alexander
Copy link
Contributor

Docs can be based on info from https://www.w3.org/TR/webrtc-stats/#webidl-2021272228

@ES-Alexander
Copy link
Contributor

Would be convenient to have some kind of info text from hovering over each field or a question mark or something, but that can be left for a later PR :-)

as it is a canvas, it could be weird, idk
-Willian

Copy link
Member

@rafaellehmkuhl rafaellehmkuhl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So cool!

One question: was the idea for the canvas to have a fixed size independent of the video widget size? I found it a little small on my screen (mac air 13in):

image

PS: thanks for putting the whole logic into another component. We are missing on doing that for other parts of the codebase and it really helps on maintenance.

@Williangalvani
Copy link
Member Author

Williangalvani commented Oct 17, 2024

So cool!

One question: was the idea for the canvas to have a fixed size independent of the video widget size? I found it a little small on my screen (mac air 13in):

yes it is small be design, I want to be able to use it without obstructing the video. While I called it stats-for-nerds, the real inspiration is Msi Afterburner overlays:
Screenshot 2024-10-16 at 22 31 29

PS: thanks for putting the whole logic into another component. We are missing on doing that for other parts of the codebase and it really helps on maintenance.

Yeah, the goal was for this to have no performance hit if disabled, as it won't even get loaded =]

@Williangalvani
Copy link
Member Author

Williangalvani commented Oct 17, 2024

having it small also allows us to use it on the secondary streams without obstructing much:

Screen.Recording.2024-10-11.at.23.10.19.1.mov

PS.: No, your dome is dirty, mine is great 🫠

@rafaellehmkuhl rafaellehmkuhl merged commit a02192a into bluerobotics:master Oct 17, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-needed Change needs to be documented
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants