system-logs: Do not log to console when system-logging is enabled #1388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Console logs can have a huge impact on performance, especially on low-end devices.
By old we mean any log older than yesterday.
rafaellehmkuhl
force-pushed
the
remove-console-logs-on-production
branch
from
eabb400
to
aa29aa2
Compare
ArturoManzoli
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Console logs can have a huge impact on performance, especially on low-end devices.
Also allows user to delete one or multiple logs.
I've also added a message to the console, before disabling it, so users that want to see the console know what to do.