[WIP] Save videos directly to filesystem (on Electron version) #1358
+147
−47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafaellehmkuhl
force-pushed
the
video-on-filesystem
branch
3 times, most recently
from
106ef48
to
23b0794
Compare
rafaellehmkuhl
force-pushed
the
video-on-filesystem
branch
from
23b0794
to
5ecff0a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code is ready but I'm having a hard time making the build process work.There are two storage implementation files, one for the browser and one for the electron build. The build process has to take that into consideration so it doesn't try to build the browser version with the electron implementation. It should not even load the file in fact, because it contains imports of Node modules, which are not available in the browser.Any help is much appreciated.Thanks @JoaoMario109 and @patrickelectric for the hand here.This is only missing the segregation of the filesystem video module to the backend and the IPC communication implementation. More on that here.