Replace SWALs with Interactive Dialogs #1161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR also fixes #291. |
rafaellehmkuhl
requested changes
Jul 30, 2024
Comment on lines
115
to
118
| } | ||
| export enum MAVLinkManualControlButton { | ||
| R0 = 'BTN0_FUNCTION', |
| constructor(public id: MAVLinkButtonFunction, public name: string) {} | ||
| constructor(public id: MAVLinkButtonFunction, public name: string) {} |
There was a problem hiding this comment.
Bad indentation also here.
ArturoManzoli
force-pushed
the
1117-Cockpit-should-use-only-interactive-dialogs
branch
3 times, most recently
from
d7db265
to
5572809
Compare
Signed-off-by: Arturo Manzoli <[email protected]>
| } | ||
| } | ||
|
|
||
| export enum MAVLinkManualControlButton { |
There was a problem hiding this comment.
This indentation was right. There's no need to touch it.
There was a problem hiding this comment.
That's weird..
My linter must be crazy
Ill check that
rafaellehmkuhl
requested changes
Jul 30, 2024
ArturoManzoli
force-pushed
the
1117-Cockpit-should-use-only-interactive-dialogs
branch
6 times, most recently
from
521f16b
to
8510e88
Compare
Signed-off-by: Arturo Manzoli <[email protected]>
Signed-off-by: Arturo Manzoli <[email protected]>
ArturoManzoli
force-pushed
the
1117-Cockpit-should-use-only-interactive-dialogs
branch
from
8510e88
to
fcf0760
Compare
rafaellehmkuhl
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1117