core: frontend: Add generic popup library #2426
Conversation
* Instal vue final modal lib for generic modals
|
I'll keep this as a draft for now because currently the popup modal is not consuming the click and keys events, so its leaking for underlying v-dialogs and mistakenly closing them |
JoaoMario109
force-pushed
the
feat-adding-generic-popup
branch
from
b9b59e7
to
792cf68
Compare
|
Added an issue in |
| fire(options: PopupOptions): Promise<PopupResult> { | ||
| return new Promise<PopupResult>((resolve) => { | ||
| this.addPopup({ | ||
| id: options.id as string, |
There was a problem hiding this comment.
why is this necessary ? isn't id a string already ?
There was a problem hiding this comment.
The ID is essentially a string. However, the popup options provide users with the flexibility to leave it unset because it is an optional property. If the user does not set it, the fire method within the Popup functionality automatically assigns a value to it. Consequently, when this data is passed to the addPopup method, it is treated as an ActivePopup. Within this context the ID is already defined either by user or fire method, so the conversion is only to remove the assignment from string | undefined from the PopupOption to the ActivePopup.
We could also change it on the Action fire to receive a direct id parameter that is already string and that will be defined in the fire method, in this way the compiler can check that is not undefined
JoaoMario109
force-pushed
the
feat-adding-generic-popup
branch
from
792cf68
to
0c7f2e7
Compare
* Add a statically mounted popup library to allow launching stackable popups and get user interaction result
JoaoMario109
force-pushed
the
feat-adding-generic-popup
branch
from
0c7f2e7
to
51cf60e
Compare
Add a generic popup component to be used when user confirmation or interaction is needed
Linked to the solution used for #2406