Allow extension links to avoid iframes #2356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Williangalvani
force-pushed
the
avoid_iframes
branch
2 times, most recently
from
891f4f2
to
7c6bfcc
Compare
Williangalvani
force-pushed
the
avoid_iframes
branch
from
7c6bfcc
to
b6b17ef
Compare
patrickelectric
approved these changes
Feb 1, 2024
ES-Alexander
added
docs-complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
some system go a long way trying to prevent being embedded into iframes. or are just plainly badly designed.
My router is an example. it does something with window.top.
This should also avoid other iframe related issues that I don't quite remember right now.
This can be tested with the
iframestag of the blueos-proxy extension