core: services: beacon: Fix V2->V3 settings migration #1920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joaoantoniocardoso
requested review from
patrickelectric,
Williangalvani and
rafaellehmkuhl
joaoantoniocardoso
force-pushed
the
fix_beacon_v3_migration
branch
2 times, most recently
from
426810c
to
8f87e23
Compare
joaoantoniocardoso
force-pushed
the
fix_beacon_v3_migration
branch
from
8f87e23
to
a9e1ddd
Compare
Williangalvani
approved these changes
Aug 1, 2023
patrickelectric
approved these changes
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1917
Details:
The settings expect the Interfaces to be:
{ "name": "uap0", "domain_names": ["blueos-hotspot"], "advertise": ["_http"], "ip": "ips[0]" }as_dictis not implemented in JsonObject, butJsonObject's._datais what we need: