core: services: wifi: Remove all wifis with same ssid in database #1899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickelectric
requested review from
Williangalvani,
joaoantoniocardoso and
rafaellehmkuhl
patrickelectric
force-pushed
the
wifi-remove-all
branch
2 times, most recently
from
cd8be22
to
6f1819b
Compare
Signed-off-by: Patrick José Pereira <[email protected]>
patrickelectric
force-pushed
the
wifi-remove-all
branch
from
6f1819b
to
399e361
Compare
| # Here we get all networks that match the ssid | ||
| # and get a list where the biggest networkid comes first. | ||
| # If we remove the lowest numbers first, it'll change the highest values to -1 | ||
| # TODO: We should move the entire wifi framestack to work with bssid |
joaoantoniocardoso
approved these changes
Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a case where the same network can be stored multiple times on the network service, this ensure that when the user remove the network, it'll remove all occurrence of the same network. We should move the service to use bssid over ssid to avoid such problems in the future;
PS: I got in a point where the same network showed 7 times