bootstrap: improve tests to test timeout detection and restarting #1882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Williangalvani
force-pushed
the
tests
branch
3 times, most recently
from
ff39df5
to
4e78377
Compare
this allows us to detect if a container was unexpectedly stopped
This makes the FakeContainer's created by bootstrap stoppable, too
patrickelectric
requested changes
Jul 19, 2023
bootstrap/test_bootstrap.py
Outdated
| bootstrapper.run() | ||
| self.mock_response.json.return_value = {"repository": ["core"]} | ||
| assert bootstrapper.is_running("core") is True | ||
| # now make it stop responing to requests |
There was a problem hiding this comment.
Suggested change
| # now make it stop responing to requests | |
| # now make it stop responding to requests |
patrickelectric
approved these changes
Jul 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
no functional changes, just covering more cases with testing,