feat: Support byte array and data URIs via mimeType #1763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gustl22
force-pushed
the
1728-uri-test-data
branch
from
c0fbb3b
to
ac2b98b
Compare
Gustl22
changed the title
2 tasks
spydon
approved these changes
Mar 15, 2024
| @@ -100,21 +119,23 @@ Future<List<LibSourceTestData>> getAudioTestDataList() async { | |||
| if (_features.hasUrlSource && _features.hasPlaylistSourceType) | |||
| m3u8UrlTestData, | |||
| if (_features.hasUrlSource) mpgaUrlTestData, | |||
| if (_features.hasDataUriSource) wavDataUriTestData, | |||
| // if (_features.hasDataUriSource) mp3DataUriTestData, | |||
There was a problem hiding this comment.
No this is just added as redundancy (like the other sources, but in a different format). But in order to make the tests faster, I commented them out. They are useful for testing certain scenarios though.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
fix:,feat:,refactor:,docs:,chore:,test:,ci:etc).///, where necessary.Breaking Change
Related Issues
Closes #1692, closes #1670, closes #1663, closes #1269