Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HelpScout Widget Fixes. #351

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

HelpScout Widget Fixes. #351

wants to merge 1 commit into from

Conversation

CNoemi94
Copy link
Collaborator

Closes #267, Closes #269, Closes #270, Closes #339

  • Added the colored NerdPress icon to the top menu link

  • Removed the "Hide Help Tab" option

  • Hid the Beacon for NerdPress users. NP users can still initiate it by clicking the "Get Help" link at the top, but this will avoid the Messages from showing for these users.

  • Removed the Beacon and Get Help link from the WP Rocket admin pages. Destroying the beacon and initiating ours didn't work for this specific beacon, so I left ours off.

  • Added an "is_wprocket()" function to check for WP Rocket admin pages

  • When we launch this, we need to set our beacon to "Hidden" in the HelpScout Global Settings

  • I just realized the WPForm flyout button is still on top of our beacon when it's open. I think we need to hide the WPForm button when the beacon is open and bring it back after. Thoughts?
    image

@CNoemi94 CNoemi94 linked an issue Aug 23, 2024 that may be closed by this pull request
@CNoemi94 CNoemi94 changed the base branch from main to dev August 23, 2024 21:51
@blogtutor
Copy link
Owner

In Slack, @CNoemi94 l said:

This is almost ready. The only thing left is the stacking of the WPForms button on top of ours. I think we need to actively hide it when our beacon is open and then bring it back after. Thoughts?

I'm not sure how big of an issue this is -- but if it's easy to hide the WPForms help form when our widget is displayed, cool. Otherwise maybe let's just not worry about it?

Removed the Beacon and Get Help link from the WP Rocket admin pages. Destroying the beacon and initiating ours didn't work for this specific beacon, so I left ours off.

I have a vague memory that we hide the WP Rocket help button for non-nerdpress users -- because we don't want our clients contacting WP Rocket. Is that not still the case?

@blogtutor
Copy link
Owner

Just discussed with Crystal. We're going to do the next release without this PR, so we don't have to rush. We'll merge this when it's ready, though! 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants