Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BENS] Multiple protocols feature #890

Merged
merged 9 commits into from
May 30, 2024
Merged

[BENS] Multiple protocols feature #890

merged 9 commits into from
May 30, 2024

Conversation

sevenzing
Copy link
Collaborator

@sevenzing sevenzing commented May 23, 2024 •
edited
Loading

  • Change config structure
  • Add option to configure multiple protocols for one chain
  • Add meta information about protocol, every endpoint with domain name now have protocol field
  • Add GET /api/v1/{chain_id}/protocols endpoint to fetch all domains
  • rewrite tests structure

@rimrakhimov
Copy link
Member

Added some small suggestions, but overall lgtm

@sevenzing sevenzing merged commit 1747840 into main May 30, 2024
3 checks passed
@sevenzing sevenzing mentioned this pull request May 30, 2024
Open
@rimrakhimov rimrakhimov deleted the ll/bens-multichain-metadata branch June 14, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rimrakhimov rimrakhimov rimrakhimov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sevenzing @rimrakhimov