Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add optional CBOR transaction representation to SUBSCRIBE_ADDRESS #245

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

iccicci
Copy link
Collaborator

@iccicci iccicci commented Oct 23, 2024

No description provided.

@iccicci iccicci force-pushed the feat/subscribe-address-cbor branch 3 times, most recently from bd7ebfd to cca73a5 Compare October 25, 2024 07:16
@iccicci iccicci marked this pull request as ready for review October 25, 2024 07:18
Copy link
Contributor

@slowbackspace slowbackspace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one small change otherwise LGTM! 🎉

src/server.ts Outdated
if (!addressesSubscribed[clientId].includes(addressInput)) {
addressesSubscribed[clientId].push(addressInput);
}
const { addresses, options } = { options: {}, ...data.params };
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small nitpick, can we please add cbor param straight to method's params instead of encapsulating it in options object?

i.e. the message would look like this:

{
    "id": 0,
    "command": "SUBSCRIBE_ADDRESS",
    "params": {
        "cbor": true,
        "addresses": [
            "..."
        ]
    }
}

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3d86ac8 should solve this

@slowbackspace
Copy link
Contributor

Ohh, could you also please add SUBSCRIBE_ADDRESS with enabled cbor as an example into the readme under the usage section (just add one more wscat message until we write proper documentation)

@iccicci
Copy link
Collaborator Author

iccicci commented Oct 25, 2024

Ohh, could you also please add SUBSCRIBE_ADDRESS with enabled cbor as an example into the readme under the usage section (just add one more wscat message until we write proper documentation)

Please let me do it with #237 i.e. my next activity.

@iccicci iccicci merged commit fb87514 into master Oct 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants