Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for PTZ service #510

Merged
merged 10 commits into from
Jul 25, 2023
Merged

Add support for PTZ service #510

merged 10 commits into from
Jul 25, 2023

Conversation

NickM-27
Copy link
Collaborator

@NickM-27 NickM-27 commented Jul 1, 2023

No description provided.

@codecov
Copy link

codecov bot commented Jul 1, 2023

Codecov Report

Merging #510 (ee95f3f) into dev (c150f9b) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##               dev      #510   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           15        15           
  Lines         1881      1896   +15     
=========================================
+ Hits          1881      1896   +15     
Files Changed Coverage Δ
custom_components/frigate/camera.py 100.00% <100.00%> (ø)
custom_components/frigate/const.py 100.00% <100.00%> (ø)

... and 3 files with indirect coverage changes

@dermotduffy dermotduffy added the enhancement New feature or request label Jul 2, 2023
@dermotduffy
Copy link
Collaborator

Overall looks great -- comments about the naming mostly.

@NickM-27 NickM-27 marked this pull request as ready for review July 24, 2023 20:43
@dermotduffy dermotduffy merged commit dead665 into blakeblackshear:dev Jul 25, 2023
6 checks passed
@dermotduffy
Copy link
Collaborator

Thanks @NickM-27 !

@NickM-27 NickM-27 deleted the ptz branch August 13, 2023 02:07
@mjwood7
Copy link

mjwood7 commented May 6, 2024

@NickM-27 - thanks for taking on adding this enhancement.

Question: when testing frigate.ptz via the developer tools in HA, if I do a move left, the camera (reolink trackmix) will spin left all the way until it hits the mechanical limit. However, in the frigate console, if I click the left move arrow for the camera, it only steps left incrementally, which is the desired behavior. Is there a way to set the incremental behavior or otherwise get it to inherit the behavior from frigate?

@NickM-27
Copy link
Collaborator Author

NickM-27 commented May 6, 2024

you call the stop service in HA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants