Multi: comply with Hugo rules for HTML comments #1757
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If an HTML starts a line within a paragraph, Hugo will end the
paragraph. E.g., this paragraph:
Mary had a little lamb
<!-- source: my childhood -->
whose fleece was white as snow.
Becomes:
<p>Mary had a little lamb</p>
<!-- source: my childhood -->
whose fleece was white as snow.
This commit adds a test to fail on any comments like that and fixes all
existing cases.
bitschmidty
approved these changes
Jul 8, 2024
There was a problem hiding this comment.
tACK
- smoke tested a few /en/ pages for visual changes, none found
- reverted one of the comment fixups and ensured it was caught by the new test
@harding ready for merge based on your other Hugo work, feel free to merge when ready
|
Rebased on latest master in combination with #1761, ran all tests, and pushed to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1551
If an HTML starts a line within a paragraph, Hugo will end the paragraph. E.g., this paragraph:
Becomes:
This commit adds a test to fail on any comments like that and fixes all existing cases.