contrib: bugfix: allow empty user.ghtoken #775
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
subprocess.run() does not throw a CalledProcessError when the process exits with a non-zero exit code, unless
check=True
is set. This means that when theoption
key is not found, an empty string is returned instead, causing a wrong ghtoken to be used for theAuthorization
header.This leads to:
Fix this and simplify the code by using the convenience function
subprocess.check_output()
instead.Addresses #764 (comment)