contrib: bugfix: allow empty user.ghtoken #775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
subprocess.run() does not throw a CalledProcessError when the process exits with a non-zero exit code, unless `check=True` is set. This means that when the `option` key is not found, an empty string is returned instead, causing a wrong ghtoken to be used for the `Authorization` header. This leads to: Github returned error HTTP Error 401: Unauthorized Fix this and simplify the code by using the convenience function `subprocess.check_output()` instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
subprocess.run() does not throw a CalledProcessError when the process exits with a non-zero exit code, unless
check=Trueis set. This means that when theoptionkey is not found, an empty string is returned instead, causing a wrong ghtoken to be used for theAuthorizationheader.This leads to:
Fix this and simplify the code by using the convenience function
subprocess.check_output()instead.Addresses #764 (comment)