fix(cli): correctly apply import sorting on --apply (#299)

CHANGELOG.md

@@ -20,6 +20,15 @@ Read our [guidelines for writing a good changelog entry](https://github.com/biom
 ### Parser
 ### VSCode
 
+## 1.2.2 (2023-09-16)
+
+### CLI
+
+#### Bug fixes
+
+- Fix a condition where import sorting wasn't applied when running `biome check --apply`
+
+
 ## 1.2.1 (2023-09-15)
 
 ### Configuration

crates/biome_cli/src/execute/process_file/organize_imports.rs

@@ -20,7 +20,7 @@ pub(crate) fn organize_imports_with_guard<'ctx>(
 
  let input = workspace_file.input()?;
  if sorted.code != input {
- if ctx.execution.is_check_apply_unsafe() {
+ if ctx.execution.is_check_apply_unsafe() || ctx.execution.is_check_apply() {
  workspace_file.update_file(sorted.code)?;
  } else {
  return Ok(FileStatus::Message(Message::Diff {

crates/biome_cli/tests/commands/check.rs

@@ -1628,7 +1628,7 @@ import * as something from "../something";
 }
 
 #[test]
-fn shows_organize_imports_diff_on_check_apply() {
+fn should_organize_imports_diff_on_check() {
  let mut fs = MemoryFileSystem::default();
  let mut console = BufferConsole::default();
 
@@ -1656,7 +1656,7 @@ import * as something from "../something";
  ),
  );
 
- assert!(result.is_err(), "run_cli returned {result:?}");
+ assert!(result.is_ok(), "run_cli returned {result:?}");
 
  let mut file = fs
  .open(file_path)
@@ -1672,7 +1672,7 @@ import * as something from "../something";
 
  assert_cli_snapshot(SnapshotPayload::new(
  module_path!(),
- "shows_organize_imports_diff_on_check_apply",
+ "should_organize_imports_diff_on_check",
  fs,
  console,
  result,

crates/biome_cli/tests/snapshots/main_commands_check/should_organize_imports_diff_on_check.snap

@@ -0,0 +1,25 @@
+---
+source: crates/biome_cli/tests/snap_test.rs
+expression: content
+---
+## `biome.json`
+
+```json
+{ "organizeImports": { "enabled": true } }
+```
+
+## `check.js`
+
+```js
+import { bar, foom, lorem } from "foo";
+import * as something from "../something";
+
+```
+
+# Emitted Messages
+
+```block
+Fixed 1 file(s) in <TIME>
+```
+
+