Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web UI Enhancements #328

Merged
merged 80 commits into from
May 9, 2024
Merged

Web UI Enhancements #328

merged 80 commits into from
May 9, 2024

Conversation

caco3
Copy link
Contributor

@caco3 caco3 commented Apr 28, 2024

  • Migrated to Bootstrap 5.3.3
  • Added dark mode. It gets persisted in the local storage of the webbrowser
  • Modal dialogs do not get closed when clicking outside of the dialog
  • Cover and control buttons are now centered
  • The cover image size is limited to 400px
  • Remove redundant texts (automatically replaced by i18n texts)
  • Automatically scroll log window down to bottom on opening it or a reload
  • Moved the header bar buttons into a hamburger menu
  • The Control button bar and the sliders (with their volume buttons resp. icons now always stay on the same line (down to a screen width of 320 px)
  • On a page reload, the previously selected tab gets reloaded
  • Added icons to the jstree context menu
  • Fixed/added some missing translations
  • Improved consistency of the overall web UI
  • Many more minor tweaks

Note: The firmware grows approx 1.3 kBytes due to this PR.

Diskussion: https://forum.espuino.de/t/darkmode/2893

@tueddy
Copy link
Collaborator

tueddy commented Apr 28, 2024

Just tested it, it already looks very good!

There are still a few visual inconsistencies, but some of them were already there before, so they might be fixed later.
The dark theme is primarily intended to reduce the brightness of Papa's mobile phone & this has already been done well.

Let us know if you think you are ready..

@caco3 caco3 marked this pull request as ready for review April 29, 2024 19:55
CaCO3 and others added 28 commits May 3, 2024 09:30
Moved language settings to general tab
truncate title if the screen gets to small
…oo long for the screen. Update to newer font awesome version
All send buttons are centered now
made distance between sections identical
added separator lines between all sections
@biologist79 biologist79 merged commit bf3af2e into biologist79:dev May 9, 2024
10 checks passed
@biologist79
Copy link
Owner

Merged into dev. Thanks a lot for your work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants