Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Ontology: Fix 'remove word' bug #998

Merged
merged 1 commit into from
Aug 21, 2023
Merged

Conversation

VesnaT
Copy link
Contributor

@VesnaT VesnaT commented Aug 21, 2023

Issue
image

Removing the bar word from the above ontology causes an error:

Traceback (most recent call last):
  File "/Users/vesna/orange3-text/orangecontrib/text/widgets/owontology.py", line 803, in __on_ontology_data_changed
    self.__set_current_modified(self.CACHED)
  File "/Users/vesna/orange3-text/orangecontrib/text/widgets/owontology.py", line 899, in __set_current_modified
    ontology = self.__ontology_view.get_data()
  File "/Users/vesna/orange3-text/orangecontrib/text/widgets/owontology.py", line 324, in get_data
    return _model_to_tree(self.__root, selection, with_selection)
  File "/Users/vesna/orange3-text/orangecontrib/text/widgets/owontology.py", line 57, in _model_to_tree
    _model_to_tree(item.child(i), selection, with_selection)
  File "/Users/vesna/orange3-text/orangecontrib/text/widgets/owontology.py", line 57, in _model_to_tree
    _model_to_tree(item.child(i), selection, with_selection)
  File "/Users/vesna/orange3-text/orangecontrib/text/widgets/owontology.py", line 57, in _model_to_tree
    _model_to_tree(item.child(i), selection, with_selection)
  File "/Users/vesna/orange3-text/orangecontrib/text/widgets/owontology.py", line 55, in _model_to_tree
    for i in range(item.rowCount()):
AttributeError: 'NoneType' object has no attribute 'rowCount'
Includes
  • Code changes
  • Tests
  • Documentation

@PrimozGodec PrimozGodec changed the title Ontology: Fix 'remove word' bug [FIX] Ontology: Fix 'remove word' bug Aug 21, 2023
@PrimozGodec
Copy link
Collaborator

Thanks for the fix. :)

@PrimozGodec PrimozGodec merged commit 743a1b1 into biolab:master Aug 21, 2023
10 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants