[ENH] Topic modelling - Reorder methods by relevance #1020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PrimozGodec
force-pushed
the
topic-change-default
branch
from
dc41ddf
to
12e7a24
Compare
PrimozGodec
commented
Nov 3, 2023
| @@ -266,6 +267,8 @@ def on_done(self, corpus): | |||
| if self.model.name == "Latent Dirichlet Allocation": | |||
| bound = self.model.model.log_perplexity(infer_ngrams_corpus(corpus)) | |||
| self.perplexity = "{:.5f}".format(np.exp2(-bound)) | |||
| else: | |||
There was a problem hiding this comment.
It seems that perplexity didn't reset to na after the method change
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1020 +/- ##
==========================================
+ Coverage 82.19% 82.21% +0.01%
==========================================
Files 93 93
Lines 12286 12294 +8
Branches 1664 1665 +1
==========================================
+ Hits 10099 10107 +8
Misses 1874 1874
Partials 313 313 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
LDA is a more relevant method than LSI, so it should be the default
Description of changes
Changing the ordering of methods and fixing settings for backwards
Includes