Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing tests #1018

Merged
merged 2 commits into from
Nov 2, 2023
Merged

Conversation

PrimozGodec
Copy link
Collaborator

Issue

Annotator tests started to fail due to changes in scikit-learn (in version 1.3.0). The reason is using the same random seed returns different results since clusters in data are not well distinguishable.

Description of changes

Fix the issue with artificial embeddings to produce better distinguishable clusters.

Includes
  • Code changes
  • Tests
  • Documentation

@codecov-commenter
Copy link

codecov-commenter commented Nov 2, 2023

Codecov Report

Merging #1018 (79a34cf) into master (6994a5b) will decrease coverage by 0.16%.
Report is 5 commits behind head on master.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1018      +/-   ##
==========================================
- Coverage   82.23%   82.07%   -0.16%     
==========================================
  Files          93       93              
  Lines       12286    12286              
  Branches     1664     1664              
==========================================
- Hits        10103    10084      -19     
- Misses       1872     1886      +14     
- Partials      311      316       +5     

@PrimozGodec PrimozGodec merged commit 3ebeaea into biolab:master Nov 2, 2023
11 of 12 checks passed
@PrimozGodec PrimozGodec deleted the fix-annotator-tests branch November 2, 2023 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants