chore(shipping): SHIPPING-3046 Update V2 shipping docs with channels #554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benpratt77
reviewed
Sep 30, 2024
benpratt77
reviewed
Sep 30, 2024
payaalaee
force-pushed
the
SHIPPING-3046-2
branch
from
08e3698
to
97785d3
Compare
bc-andreadao
previously approved these changes
Sep 30, 2024
|
Thanks @payaalaee . I created PR 556 so we can talk about the use cases & limitations in the doc, if you could review/approve |
theromulans
reviewed
Oct 1, 2024
theromulans
reviewed
Oct 1, 2024
theromulans
reviewed
Oct 1, 2024
payaalaee
force-pushed
the
SHIPPING-3046-2
branch
from
97785d3
to
28665a9
Compare
theromulans
reviewed
Oct 7, 2024
payaalaee
force-pushed
the
SHIPPING-3046-2
branch
from
28665a9
to
b6915a5
Compare
theromulans
approved these changes
Oct 8, 2024
benpratt77
approved these changes
Oct 8, 2024
bc-andreadao
reviewed
Oct 8, 2024
|
|
||
| | Property | Type | Description | | ||
| | - | - | - | | ||
| | channels | array | Channels associated with the method as an array of integers | |
There was a problem hiding this comment.
Suggested change
| | channels | array | Channels associated with the method as an array of integers | | |
| | channels | array | Channels associated with the method as an array of integers. | |
bc-andreadao
reviewed
Oct 8, 2024
|
|
||
| | Property | Type | Description | | ||
| | - | - | - | | ||
| | channels | array | Channels associated with the method as an array of integers | |
There was a problem hiding this comment.
Suggested change
| | channels | array | Channels associated with the method as an array of integers | | |
| | channels | array | Channels associated with the method as an array of integers. | |
bc-andreadao
reviewed
Oct 8, 2024
|
|
||
| | Property | Type | Description | | ||
| | - | - | - | | ||
| | channels | array | Channels associated with the method as an array of integers | |
There was a problem hiding this comment.
Suggested change
| | channels | array | Channels associated with the method as an array of integers | | |
| | channels | array | Channels associated with the method as an array of integers. | |
bc-andreadao
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SHIPPING-3046
What changed?
Release notes draft
As a part of MSF project and introducing channels, we want to update our docs to reflect the new feature.
channelsfiled is the list of channels associated with a method.Anything else?
N/A
ping @bigcommerce/team-shipping @bc-andreadao