Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEVDOCS-5714: Tax Zone API, add tax zone check endpoint #54

Merged
merged 6 commits into from
Jan 26, 2024
Merged

DEVDOCS-5714: Tax Zone API, add tax zone check endpoint #54

merged 6 commits into from
Jan 26, 2024

Conversation

bc-andreadao
Copy link
Collaborator

@bc-andreadao bc-andreadao commented Jan 24, 2024 •
edited
Loading

DEVDOCS-5714

This PR is a continuation of PR 12

What changed?

  • Add Tax Zone Check endpoint to Tax Zones API reference
  • Add new endpoint examples to Tax Zones doc
  • Deleted (unused) file

Release notes draft

The newly-released Tax Zone Check endpoint is now available to use. Now, you’ll be able to check the tax zone that applies to a given region and customer group.

Anything else?

cc @bigcommerce/team-tax

@bc-andreadao bc-andreadao marked this pull request as ready for review January 24, 2024 20:29
@bc-andreadao bc-andreadao mentioned this pull request Jan 24, 2024
Merged
bc-traciporter
bc-traciporter reviewed Jan 25, 2024
View reviewed changes
Copy link
Collaborator

@bc-traciporter bc-traciporter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might want to change "Tax Zones reference" to "Tax zone reference" on line 452.

docs/api-docs/tax/tax-rates-zones.mdx Outdated Show resolved Hide resolved
docs/api-docs/tax/tax-rates-zones.mdx Show resolved Hide resolved
bc-traciporter
bc-traciporter approved these changes Jan 25, 2024
View reviewed changes
Copy link
Collaborator

@bc-traciporter bc-traciporter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bc-andreadao bc-andreadao merged commit 4036c6c into main Jan 26, 2024
5 checks passed
@bc-andreadao bc-andreadao deleted the DEVDOCS-5714-tax-zone-check branch January 26, 2024 15:17
@matthewvolk matthewvolk mentioned this pull request Feb 17, 2024
Merged
bc-tgomez pushed a commit that referenced this pull request Apr 26, 2024
@bc-andreadao @bc-tgomez
DEVDOCS-5714: Tax Zone API, add tax zone check endpoint (#54)
a4b0800
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benpratt77 benpratt77 benpratt77 left review comments

@bc-traciporter bc-traciporter bc-traciporter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bc-andreadao @benpratt77 @bc-traciporter