Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(checkout): CHECKOUT-8516 Add Shipping Discount to Cart Page #2490

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

valentindellangela
Copy link

What?

We are working on a new feature to allow shipping discount to be created on the promotion side and applied to a cart with a selected shipping option.

This ticket is about showing the discount on the cart page and will be composed of 2 tickets:

This feature is protected behind a LaunchDarkly Experiment and will be slowly ramped up when the feature development is complete.

Tickets / Documentation

Screenshots (if appropriate)

Tested using Stencil CLI:

Without Shipping Discount:
image

With Shipping Discount:
image

ping @bigcommerce/team-checkout

@valentindellangela
Copy link
Author

image

Seems to be failing on each PRs 🤷‍♂️

@valentindellangela
Copy link
Author

valentindellangela commented Oct 14, 2024

Hi @bigcommerce/team-themes

Are you please able to:

  • review my PR
  • let me know if there is a way to confirm it won't break any functional tests - I don't expect any but I don't know how to double-check
  • help me release it if everything looks safe

Thanks!

@bc-yevhenii-buliuk
Copy link
Contributor

@valentindellangela LGTM, but add please the CHANGELOG.md file with the appropriate changes

@valentindellangela
Copy link
Author

@bc-yevhenii-buliuk Thanks, I've updated the CHANGELOG.md.
I suppose the flow is to merge this anytime and then at some point the theme team will create a release?

@bc-yevhenii-buliuk
Copy link
Contributor

bc-yevhenii-buliuk commented Oct 15, 2024

@bc-yevhenii-buliuk Thanks, I've updated the CHANGELOG.md. I suppose the flow is to merge this anytime and then at some point the theme team will create a release?

@valentindellangela right now, our team is busy with the release process, so your PR can be merged after the release. I added the label do not merge temporarily until we finalize the release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants