sortmerna: finish update #1338
Merged
sortmerna: finish update #1338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
followup on bgruening#1316 which was not deployed - use the same chached data for chached and cached_to_index i.e. now they differ only in that the later uses the dbprep macro if I get it right previously the datamanager precomputed indexes which could be used. this seems not possible anymore I suggest to leave the dm untouched (than the provided data will also work for old sortmerna versions) - fix usage of cached data (did not work for multiple provided values) and add tests
|
Tests are failing here now :( |
selects default to optional="true" which should not apply here. also checkboxes do not work therefore.
bernt-matthias
force-pushed
the
update_sortmerna2
branch
from
053240a
to
4c306ed
Compare
bgruening
approved these changes
Oct 20, 2023
|
Hrm. toolshed is in bad mood today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
followup on #1316 which was not deployed
ping @bgruening
use the same chached data for chached and cached_to_index i.e. now they differ only in that the later uses the dbprep macro
if I get it right previously the datamanager precomputed indexes which could be used. this seems not possible anymore
I suggest to leave the dm untouched (than the provided data will also work for old sortmerna versions)
fix usage of cached data (did not work for multiple provided values) and add tests