Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support local-only no remote-related deps #183

Merged
merged 2 commits into from
Sep 16, 2024
Merged

Conversation

digizeph
Copy link
Member

@digizeph digizeph commented Sep 14, 2024

This PR allows users to use this library to process only local files without bringing in all the remote-related dependencies like reqwest. This addresses #181

Changes

  • removing remote feature from oneio default features
  • make oneio non-optional with only gz and bz features by default
  • make rustls and native-tls enables oneio/remote

there is no breaking changes

Copy link

codecov bot commented Sep 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.15%. Comparing base (136bdff) to head (aaeb10c).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #183   +/-   ##
=======================================
  Coverage   93.15%   93.15%           
=======================================
  Files          65       65           
  Lines        8225     8225           
=======================================
  Hits         7662     7662           
  Misses        563      563           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@digizeph digizeph merged commit 74eb145 into main Sep 16, 2024
6 checks passed
@digizeph digizeph deleted the feature/local_only branch September 16, 2024 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant