Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve BMP dx #165

Merged
merged 6 commits into from
Apr 12, 2024
Merged

improve BMP dx #165

merged 6 commits into from
Apr 12, 2024

Conversation

digizeph
Copy link
Member

BMP messages SDK improvements

  • expose all pub structs and enums for BMP messages
    • this allows users to access struct definitions and operate on them directly
  • added Copy to BmpMsgType, BmpPeerType and BmpPerPeerHeader, PerPeerFlags, BmpPeerType
  • implemented Default, PartialEq, Eq and Hash for BmpPerPeerHeader
    • this allows users and compare and hash BmpPerPeerHeader structs
    • also implemented .strip_timestamp() to remove the timestamp from the BmpPerPeerHeader struct for cases where
      the timestamp is not needed

Copy link

codecov bot commented Apr 10, 2024

Codecov Report

Attention: Patch coverage is 91.37931% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 93.09%. Comparing base (51f8540) to head (8306d6d).
Report is 2 commits behind head on main.

❗ Current head 8306d6d differs from pull request most recent head f9b2217. Consider uploading reports for the commit f9b2217 to get more accurate results

Files Patch % Lines
src/parser/bmp/mod.rs 28.57% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #165      +/-   ##
==========================================
+ Coverage   93.05%   93.09%   +0.03%     
==========================================
  Files          65       65              
  Lines        8304     8351      +47     
==========================================
+ Hits         7727     7774      +47     
  Misses        577      577              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@digizeph digizeph merged commit 9522de9 into main Apr 12, 2024
3 checks passed
@digizeph digizeph deleted the feature/expose-bmp-header-fields branch April 12, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant